-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does quill support image upload? #90
Comments
Would I be right in thinking that this would be a module? Since the server side, upload presentation and execution varies wildly from application to application. Could it be a third-party module that we include rather than the core project deciding how uploads should be handled? Then its up to the developer to pick which one will work for them. After using ckeditor for a long time I really like how simple quill is and would hate to see it turn into a behemoth like ckeditor. |
The hosting files part is definitely outside of Quill's scope but I think it could do more than it currently does. For example, one possibility is you just supply Quill with a server endpoint for uploads but the UI for drag and drop and choosing a file for upload could be handled by Quill (it would be organized as a module but one of the officially supported ones). A guide or example on using imgur or s3 for this could be provided as well. |
👍 to have a supported module for the UI. I'm looking to move over to Quill and we already have server-side image upload support (for a custom plugin to Ext's HTMLEditor) and would love to have that support in QuillJS too! |
I think this is available? https://github.com/quilljs/quill/blob/develop/src/modules/image-tooltip.js |
That's more of an image import from remote URL than image upload. |
Here's some basic integration with the Dropzone.js library https://github.com/swim/quill-dropzone - please note; this does not handle any server side code. |
I'm deleting all +1s so the comments can be easier to find. Please use the reaction feature to show support. |
Images should just be handled with a callback function. onImage(data) {
return server.upload(data)
.then(imageUrl => {
return imageUrl
})
} |
how does that work together with the default image upload from the snow theme ? please |
@daslicht This is my code, lots there that you do not need, but it should be easy to figure out.
|
What about when the image is deleted? That needs to be handled somehow server-side as well. |
@kyrofa I just don't deal with that yet. Space is cheap. I do track when images were last used, so worst case if space gets tight, I can just delete images that haven't been accessed in years. |
I face another issue after handling upload images to the server instead of generating a base64 string. |
Sounds like you have a front-end GUI bug, try opening a new ticket or review your console for any errors. |
did you solve it , can we upload our image to a cloud server like cloudinary or firebase then use it in our rich text (in the same order) |
I have made a server-side script to upload to Firebase Storage as I was looking for the same answer you never found out here. In your function that receive the content from quill editor (server-side)
If you need it as well, here is my uploadImageToStorage function
|
Hi,
Quill is an excellent editor!!
May I know whether quill support image upload?any demo server side script?
Many thanks.
The text was updated successfully, but these errors were encountered: