-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browserify-able npm module #274
Comments
To clarify you are trying to run command line browserify on a file that required Quill? |
Yes; sorry, should have been more clear. I am using browserify (through gulp) to build my project and Quill is a dependency in my project. Steps to reproduce would be:
Where app.js: var Quill = require('quill'); The browserify errors are all missing dependencies that correspond to the requires inside quill.js. It gets to that point so I don't think the issues is the browser field in package.json as mentioned in issue #272. If you see this issue it can be resolved by adding an additional step to the browserify build. I'm afraid I'm not a grunt or coffeescript guy, else I would have given a pull request a go. Thanks. |
No worries those two linked issues were very helpful in getting to the bottom of this. |
This is great. Thanks a lot! |
The current dist errors when required through browserify.
Browserify is not smart and tries resolving every
require()
it comes across, even the ones which have already been resolved (i.e. this file). This shouldn't be happening since the dist build has the standalone option. Using the .min file fixes this but it isn't included in the npm distribution.According to this comment on a browserify issue derequire was removed from the standalone option, and it needs to be added as an additional transform.
The text was updated successfully, but these errors were encountered: