Skip to content

Invalid setSelection call signature in getFormat documentation #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philraj opened this issue Jan 4, 2019 · 2 comments
Closed

Invalid setSelection call signature in getFormat documentation #2451

philraj opened this issue Jan 4, 2019 · 2 comments

Comments

@philraj
Copy link
Contributor

philraj commented Jan 4, 2019

Docs for getFormat seem to use an invalid form of setSelection.

Steps for Reproduction

  1. Visit https://quilljs.com/docs/api/#getformat
  2. Look at the examples, where it says quill.setSelection(3)

According to the setSelection docs, this isn't a valid setSelection call signature.

Expected behavior:
Examples should show valid call syntax.

Actual behavior:
Examples appear to use invalid syntax.

Platforms:
Everything.

Version:
This is documentation.
@jhchen
Copy link
Member

jhchen commented Jan 4, 2019

quill.setSelection(3) is valid but the setSelection look like the second parameter is missing the fact it has a default value of 0. Would you mind submitting a PR to add this?

@philraj
Copy link
Contributor Author

philraj commented Jan 4, 2019

#2452
Like this?

@philraj philraj closed this as completed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhchen @philraj