Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing using Chinese keyboard in iOS9.3.3 if inline style is active will double the input result. #1921

Closed
icewind7030 opened this issue Jan 18, 2018 · 6 comments

Comments

@icewind7030
Copy link

icewind7030 commented Jan 18, 2018

Typing using Chinese keyboard in iOS9.3.3 if inline style is active will double the input result.

Steps for Reproduction

  1. Visit quilljs.com with safari in iOS9.3.3.
  2. Toggle 'bold' style active.
  3. Typing using Chinese keyboard.
    See the video of reproduction.
    https://youtu.be/4M7eAV0eVB0

Expected behavior:
Get the only one copy of word in IME to editor.
Actual behavior:
The word in IME got doubled and show in the editor.
Platforms:
iOS9.3.3 Safari

Version:
1.3.4

@hiYoHoo
Copy link

hiYoHoo commented Jul 26, 2018

请问你有解决这个问题吗

@icewind7030
Copy link
Author

@hiYoHoo
quilljs

我好像是修改了core/selection.js这个文件解决的,时间太久了,你可以试试

@WinMinTun
Copy link

@icewind7030 @hiYoHoo Is it ok now? Can someone tell me pls? My Chinese sucks. I m having the similar problem in #2305

@icewind7030
Copy link
Author

@WinMinTun I tweak the core/selection.js a little just like the image I posted, it seems fixed the problem, and I chose not to update my quill.js file together with the origin repository any more. So I can not be sure it works for now or is it still a problem since the origin repository changes a lot.
The code I added is below:

this.emitter.emit(Emitter.events.TEXT_CHANGE, null, null, Emitter.sources.USER);
if(/iPhone OS 9/i.test(navigator.userAgent) || /iPhone OS 10/i.test(navigator.userAgent)) return;

@WinMinTun
Copy link

@icewind7030 Thanks. I tried but not ok (version 1.3.6). What are the events compositionstart and compositionend? Any help really appreciated. I desperately need an authorship module. Whenever I apply authorship attribute to delta the keyboard gone messed as in #2305

@quill-bot
Copy link

Quill 2.0 has been released (announcement post) with many changes and fixes. If this is still an issue please create a new issue after reviewing our updated Contributing guide 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants