Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checked list item loses indentation #1818

Closed
DmitrySkripkin opened this issue Nov 13, 2017 · 2 comments
Closed

Checked list item loses indentation #1818

DmitrySkripkin opened this issue Nov 13, 2017 · 2 comments

Comments

@DmitrySkripkin
Copy link

When you hit Enter/Return after checked list item, it loses indentation.

Steps for Reproduction

  1. Visit codepen.io
  2. Set caret after "two"
  3. Hit Enter/Return (BTW Shift + Enter/Return works ok)

Expected behavior:
New empty list item with same indent created

Actual behavior:
New empty list item with same indent created, but old list item lose indentation

Ubuntu 16.04, latest Chrome (but I think it doesn't matter):

Version:
1.3.4

@DmitrySkripkin
Copy link
Author

checklist enter keyboard handler is the reason, don't know what is the usecase for it. But it works in a different way for checked and unchecked list items.

@jhchen jhchen closed this as completed in 242e166 Jan 22, 2018
@jhchen
Copy link
Member

jhchen commented Jan 22, 2018

The purpose of the handler was to make new checklist items unchecked, but the logic was losing the indent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants