Changing hyperlink fails.

[byronm]

1. Select (or place the cursor within) hyperlinked text
2. Click change on the link-tooltip
3. Change the url value
4. Click done

Though the link-tooltip UI works fine, the formatted text retains the original url instead of the newly set one. Logging the call to formatText I see that the range is length 0, so seems like an issue with the range saving and selection change event.

[timcosta]

actually, my fix for this isnt 100% complete.

is desired behavior to change the formatted text ONLY when the formatted text is exactly the old link, or change the formatted text regardless?

[jhchen]

The href should be changed regardless of what the text of the link is.

[timcosta]

Agreed, however I asked about changing the formatted text, not the href. My current PR changes the href regardless.

[jhchen]

Hmm I think I'm confused by the question then. The only way you can change the textual content right now is by typing, regardless of the format whether it's bolded, linked, or otherwise. Maybe if you provide a specific scenario?

[timcosta]

Currently, when you create a link out of selected text it all works fine. If you attempt to change the URL of the link after using the tooltip, the href of the actual is not updated. This can be verified by viewing the inspector in Chrome/FF.

My PR fixes the issue of not updated the href of the tag.

I am asking if the desired functionality is to also change the formatted text <a>THIS TEXT</a> to the new URL because the issue talks about the formattedText retaining the old URL, which I would expect.

[jhchen]

Ah I see. Thank you for the clarification. No it should not change the formatted text. In the future we may have the link tooltip also have a text field (similar to how Gmail/GDocs works) but for now the tooltip should just control the href.

[timcosta]

alright. well in that case I believe this PR is ready to be accepted. I am not sure how to check the functionality of the Deltas in relation to my change, so that is something I would appreciate help testing.