Still getting warnings

[allaire]

See screenshot below:

[allaire]

@skywinder Any updates?

[skywinder]

And can't reproduce it.
I don't see any warnings in Xcode.
I will try to investigate this issue later.

[skywinder]

It seems the something wrong with warnings flags. I can't reproduce it.
Until it is not fixed, just ignore it.
If someone can fix it - I will be glad to merge it.

[LeoSnek]

I get the same warnings:

AbstractActionSheetPicker.m:369:45: 'sizeWithFont:' is deprecated: first deprecated in iOS 7.0 - Use -sizeWithAttributes:
AbstractActionSheetPicker.m:476:20: 'contentSizeForViewInPopover' is deprecated: first deprecated in iOS 7.0 - Use UIViewController.preferredContentSize instead.
ActionSheetStringPicker.m:100:82: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'

The first two only appear if the deployment target is set to at least 7.0.

[funnel20]

I can confirm the warnings, I have also set the minimum deployment target to iOS 7.0.

The if-else statement to use sizeWithFont or sizeWithAttributes is based on:

if ( NSFoundationVersionNumber > NSFoundationVersionNumber_iOS_6_1)

sizeWithAttributes is available since iOS 7.0. And so is NSFoundationVersionNumber_iOS_6_1.

What will happen if this code runs on iOS 6? Will it crash on NSFoundationVersionNumber_iOS_6_1?

[skywinder]

@funnel20 No. This project fully compatible with iOS 6-7-8. And this check is needed to support all of them at once. Just ignore these warnings.

I don't know where is the problem.
I fix all issues. I add pragmas to mute warrnings.
I run Xcode analyze and it says me "no issues".
Probably something wrong with my settings of Xcode, but I have no idea how to fix it.

But I assure you, that it's nothing wrong with this code.

[skywinder]

Ok, Guys. I figure out, what cause ignoring this warnings in my IDE:
I was work with iOS deployment target 6.1. And thats why I didn't see any warnings.
Now it fixed. Thanks for patience.
Please, update to 1.1.6

[funnel20]

Thanks for the fix, warnings are gone.

[funnel20]

Hi Petr,

Thanks for fixing this.

Are you planning to tag a new stable release?
The last release is at 1.0.10.
I tried the master version a few days ago, but that didn't show the Sheet at all.
1.0.10 works fine, therefor I switched to it.

With kind regards,

Martijn

On 27 Aug 2014, at 10:41 PM, Petr Korolev [email protected] wrote:

Ok, Guys. I figure out, what cause ignoring this warnings in my IDE:
I was work with iOS deployment target 6.1. And thats why I didn't see any warnings.
Now it fixed. Thanks for patience.

—
Reply to this email directly or view it on GitHub.

[skywinder]

@funnel20 sorry for confusion with versions, especially with 1.0.x.
I do not remember which of 1.0.x versions is stable. May fault.
But I highly recommend to you update to 1.1.5. Now it most stable version.

[funnel20]

@skywinder I first updated to version 1.1.5, that worked fine.
Now I have updated to 1.1.8 that solved the 3 compiler warnings from this issue and runs fine.
Thanks

[skywinder]

You're welcome.
I'll try to not commit in 1.1.x some any dangerous fetaures, only bugfixes.
Stay tuned!