Skip to content

Conversation

@lloyd-brown
Copy link
Collaborator

@lloyd-brown lloyd-brown commented Nov 3, 2025

This PR fixes two issues with smoke test blocking release:

  • The first is with test_launch_fast_with_autostop which is failing due to a new python warning message in the output not expected by the test, we've added an env variable to suppress these warnings in the future.
  • The second is with test_managed_jobs_storage, it currently times out because provisioning a spot instance on GCP takes too long, I've increased the timeout.

Both smoke test pass now https://buildkite.com/skypilot-1/smoke-tests/builds?branch=lloyd%2Ffix-release-build.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@lloyd-brown
Copy link
Collaborator Author

/smoke-test -k test_managed_jobs_storage --gcp

@lloyd-brown
Copy link
Collaborator Author

/smoke-test -k test_launch_fast_with_autostop --gcp

@lloyd-brown lloyd-brown changed the title [Debug] [Test] Fix Release Failures Nov 3, 2025
@lloyd-brown
Copy link
Collaborator Author

/smoke-test -k test_launch_fast_with_autostop --gcp

@lloyd-brown lloyd-brown marked this pull request as ready for review November 3, 2025 20:10
@lloyd-brown
Copy link
Collaborator Author

/smoke-test -k test_launch_fast_with_autostop --gcp

Copy link
Collaborator

@SeungjinYang SeungjinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lloyd-brown!

@lloyd-brown
Copy link
Collaborator Author

/smoke-test -k test_endpoint_output_basic

@lloyd-brown lloyd-brown merged commit 434f9e0 into master Nov 3, 2025
21 checks passed
@lloyd-brown lloyd-brown deleted the lloyd/fix-release-build branch November 3, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants