fail in developer mode if sync filelock is being used in async codepath #7750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeungjinYang
force-pushed
the
req-filelock-async-check
branch
3 times, most recently
from
a6eb9fe to
afa68b5
Compare
SeungjinYang
changed the title
Collaborator
|
Can we make sure that SKYPILOT_DEV is set in buildkite and then just run every smoke test ever on this |
SeungjinYang
changed the title
SeungjinYang
force-pushed
the
req-filelock-async-check
branch
from
a24fbdf to
1369269
Compare
cg505
reviewed
Oct 29, 2025
Collaborator
cg505
left a comment
cg505
left a comment
There was a problem hiding this comment.
I was thinking more like we wrap the FileLock class itself and only use the wrapped version, otherwise we have to remember to add this at every callsite. If you are worried about the overhead you could also do something like:
class WrappedFileLock:
...
if env_options.Options.IS_DEVELOPER.get():
FileLock = WrappedFileLock
else:
FileLock = filelock.FileLock
| """Get and update a SkyPilot API request.""" | ||
| # In developer mode, we assert if synchronous filelock is | ||
| # being used in an async context. | ||
| if (env_options.Options.IS_DEVELOPER.get() and not _is_running_pytest() and |
Collaborator
There was a problem hiding this comment.
Why not _is_running_pytest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)