Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sky Launch] SSH to Machine during first run of sky launch #385

Closed
michaelzhiluo opened this issue Feb 20, 2022 · 1 comment
Closed

[Sky Launch] SSH to Machine during first run of sky launch #385

michaelzhiluo opened this issue Feb 20, 2022 · 1 comment

Comments

@michaelzhiluo
Copy link
Collaborator

It looks like the steps that allow the user to authenticate and access the machine (modifications to ~/.ssh/config) are done after ray up is complete. This raises a bigger issue, what if the user wants to ssh to the machine in the middle of ray up.

This is a likely case, since initial users may lose patience when sky launch is taking too long and want to see what is wrong with their provisioned node.

Potential Fix (suggested by @Michaelvll): ray up with empty config to setup ~/.ssh/sky-key and ~/.ssh/config as soon as possible. Then, ray up with full yaml.

@michaelzhiluo michaelzhiluo changed the title [Sky Launch] [Sky Launch] SSH to Machine during first run of sky launch Feb 20, 2022
@Michaelvll Michaelvll added the P0 label Feb 22, 2022
@Michaelvll
Copy link
Collaborator

This problem is largely mitigated by #400 and #407, since the user can ssh into the instance even the setup or file_mounts fails. Closing, please open another one if the problem still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants