Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map downloading from PAK file with allow_download_maps set to 1 #345

Closed
ThePhatman opened this issue Feb 15, 2024 · 4 comments
Closed

Map downloading from PAK file with allow_download_maps set to 1 #345

ThePhatman opened this issue Feb 15, 2024 · 4 comments

Comments

@ThePhatman
Copy link

My Q2PRO dedicated server seems to be allowing clients to download map files from a PAK file over UDP, even with allow_download_maps set to 1.

These are the relevant settings in my server configuration:

set allow_download 1
set allow_download_maps 1

Version I am running is r3079

@ThePhatman
Copy link
Author

Oh and I verified that the map file was not in the maps directory.
It was definitely coming from the PAK file.

@skullernet
Copy link
Owner

Logic to specially handle maps coming from PAK files has been removed quite a while ago in commit 205c61d. Looks like I forgot to update allow_download_maps documentation when removing it.

@ThePhatman
Copy link
Author

And this behaviour is only for maps, as opposed to models?

@skullernet
Copy link
Owner

Only maps from PAK files have been handled specially before mentioned commit. After that commit, all allow_download_* cvars behave the same (accept either zero or non-zero).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants