Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

Commit 510f24f

Browse files
committed
only show bar when a cell is selected
1 parent 67f20cb commit 510f24f

File tree

3 files changed

+22
-1
lines changed

3 files changed

+22
-1
lines changed

src/skrubview/_data/templates/skrubview.js

+4
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,8 @@ function displayValue(event) {
136136

137137
const topBarId = table.dataset.topBarId;
138138
const bar = document.getElementById(topBarId);
139+
document.querySelector(".skrubview-top-bar").removeAttribute("data-hidden");
140+
document.querySelector(".skrubview-top-bar-placeholder").setAttribute("data-hidden", "");
139141
bar.setAttribute("data-content-table-cell-value", elem.dataset.valueStr);
140142
bar.setAttribute("data-content-table-cell-repr", elem.dataset.valueRepr);
141143
bar.setAttribute("data-content-table-column-name", elem.dataset.colNameStr);
@@ -161,6 +163,8 @@ function clearTableCellSelection(tableElem){
161163
tableElem.removeAttribute("data-selected-cell");
162164
const topBarId = tableElem.dataset.topBarId;
163165
const bar = document.getElementById(topBarId);
166+
document.querySelector(".skrubview-top-bar").setAttribute("data-hidden", "");
167+
document.querySelector(".skrubview-top-bar-placeholder").removeAttribute("data-hidden");
164168
bar.removeAttribute("data-content-table-cell-value");
165169
bar.removeAttribute("data-content-table-cell-repr");
166170
bar.removeAttribute("data-content-table-column-name");

src/skrubview/_data/templates/top-bar.css

+14
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,17 @@
22
flex-grow: 1;
33
max-width: 70rem;
44
}
5+
6+
{{ report_id_selector }}.skrubview-report .skrubview-top-bar[data-hidden] {
7+
display: none;
8+
}
9+
10+
{{ report_id_selector }}.skrubview-report .skrubview-top-bar-placeholder {
11+
font-size: var(--skrubview-large);
12+
padding-block-start: var(--skrubview-huge);
13+
padding-block-end: var(--skrubview-huge);
14+
}
15+
16+
{{ report_id_selector }}.skrubview-report .skrubview-top-bar-placeholder[data-hidden] {
17+
display: none;
18+
}

src/skrubview/_data/templates/top-bar.html

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
<div id="{{ top_bar_id }}" class="skrubview-flex skrubview-flex-wrap skrubview-wrapper skrubview-top-bar">
1+
<div class="skrubview-top-bar-placeholder skrubview-text">
2+
Click on a table cell below to display more information.
3+
</div>
4+
<div id="{{ top_bar_id }}" class="skrubview-flex skrubview-flex-wrap skrubview-wrapper skrubview-top-bar" data-hidden="">
25
<select id="{{ top_bar_select_id }}" onchange="updateBarContent('{{ top_bar_display_id }}')" data-bar-id="{{ top_bar_display_id }}" autocomplete="off">
36

47
<option value="table-column-name"

0 commit comments

Comments
 (0)