Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard buffer reset #65

Open
jinshin opened this issue Feb 28, 2024 · 0 comments
Open

Keyboard buffer reset #65

jinshin opened this issue Feb 28, 2024 · 0 comments

Comments

@jinshin
Copy link

jinshin commented Feb 28, 2024

Hi Sergey!
Not a bug or issue, just a quick question:
What is the actual purpose of

8088_bios/src/bios.asm

Lines 1057 to 1065 in 8fd8cea

mov cx,1000
.kbd_flush:
mov ah,01h
int 16h
jz .kbd_no_key
mov ah,00h
int 16h
.kbd_no_key:
loop .kbd_flush

It's called right before keyboard buffer reset, so i think it's not needed, unless you wanted to do a stuck key detect there?

Also a suggestion - clean up keyboard buffer before entering settings loop, as entering a key several times causes menu reprint and that is quite slow thing. Like this:

.menu_loop:
	mov	si,msg_set_prompt
	call	print

.menu_input:				; cleanup buffer before start preocessing input
	mov	ah,01
	int	16h
	jz	.menu_next
	mov	ah,00
	int	16h
	jmp	.menu_input
.menu_next:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant