Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imaginary type and IEC 60559-compatible complex arithmetic #1

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

skirpichev
Copy link
Owner

@skirpichev skirpichev commented May 25, 2024

"Generally, mixed-mode arithmetic combining real and complex variables should be performed directly, not by first coercing the real to complex, lest the sign of zero be rendered uninformative; the same goes for combinations of pure imaginary quantities with complex variables." (c) Kahan, W: Branch cuts for complex elementary functions.

That's why C standards since C99 introduce imaginary types. This patch proposes similar extension to the Python language:

  • Added a new subtype (imaginary) of the complex type. New type has few overloaded methods (conjugate() and __getnewargs__()).
  • Complex and imaginary types implement IEC 60559-compatible complex arithmetic (as specified by C11 Annex G).
  • Imaginary literals now produce instances of imaginary type.
  • cmath.infj/nanj were changed to be of imaginary type.
  • Modules ast, code, copy, marshal got support for imaginary type.
  • Few tests (test_fractions.py, test_socket.py and test_str.py) adapted to use complex, instead of imaginary literals.
  • Print dot for signed zeros in the real part of repr(complex).
  • repr(complex) also now prints real part even if it's zero.

Lets consider (actually interrelated) problems, shown for unpatched code, which will be solved on this way.

  1. First, new code allows to use complex arithmetic for implementation of mathematical functions without special "corner cases". Take the inverse tangent as an example:
>>> z = complex(-0.0, 2)
>>> cmath.atan(z)
(-1.5707963267948966+0.5493061443340549j)
>>> 1j*(cmath.log(1 - 1j*z) - cmath.log(1 + 1j*z))/2  # real part was wrong
(1.5707963267948966+0.5493061443340549j)
  1. Previously, we have only unsigned imaginary literals with the following semantics:
±a±bj = complex(±float(a), 0.0) ± complex(0.0, float(b))

While this behaviour was well documented, most users would expect instead here:

±a±bj = complex(±float(a), ±float(b))

i.e. that it follows to the rectangular notation for complex numbers.

For example:

>>> -0.0+1j  # now (-0.0+1j)
1j
>>> float('inf')*1j  # now infj
(nan+infj)
  1. The eval(repr(x)) == x invariant was broken for the complex type. Below are simple examples with signed zero:
>>> complex(-0.0, 1.0)  # also note funny signed integer zero below
(-0+1j)
>>> -0+1j
1j
>>> complex(0.0, -cmath.inf)
-infj
>>> -cmath.infj
(-0-infj)

See also ISO/IEC 9899:2011, Annex G and Rationale for C99 and Augmenting a Programming Language with Complex Arithmetic.


📚 Documentation preview 📚: https://cpython-previews--1.org.readthedocs.build/

@skirpichev skirpichev force-pushed the imaginary-class-109218 branch 2 times, most recently from 7323971 to 99d1b8c Compare May 25, 2024 13:45
@skirpichev skirpichev marked this pull request as ready for review June 4, 2024 05:57
@skirpichev skirpichev changed the title gh-109218: Imaginary type and IEC 60559-compatible complex arithmetic Imaginary type and IEC 60559-compatible complex arithmetic Jun 9, 2024
@skirpichev skirpichev force-pushed the imaginary-class-109218 branch 2 times, most recently from 4db428d to 6f13b24 Compare June 14, 2024 12:19
@skirpichev skirpichev force-pushed the imaginary-class-109218 branch 3 times, most recently from 4ca3e9a to c114f16 Compare June 29, 2024 09:16
skirpichev pushed a commit that referenced this pull request Jul 21, 2024
…ython#119498) (#1… (python#119905)

Revert "[3.12] pythongh-69214: Fix fcntl.ioctl() request type (python#119498) (python#119505)"

This reverts commit 078da88.

The change modified how negative values, like termios.TIOCSWINSZ, was
treated and is actually backward incompatible.
@skirpichev skirpichev force-pushed the imaginary-class-109218 branch from 36c6bf5 to 7e68e91 Compare July 25, 2024 07:51
@skirpichev skirpichev force-pushed the imaginary-class-109218 branch from 6a44153 to d605b8e Compare August 3, 2024 07:19
@skirpichev skirpichev force-pushed the imaginary-class-109218 branch from 2c3d2b4 to db12274 Compare October 1, 2024 04:15
@skirpichev skirpichev force-pushed the imaginary-class-109218 branch 2 times, most recently from 45dfe36 to f9edb38 Compare November 27, 2024 01:14
@skirpichev skirpichev marked this pull request as draft November 27, 2024 01:14
@skirpichev skirpichev force-pushed the imaginary-class-109218 branch 2 times, most recently from 36a5a26 to 517a029 Compare November 27, 2024 04:14
rruuaanng and others added 6 commits November 27, 2024 06:53
…nGH-127256)

Remove seriously outdated netlink constants.

Co-authored-by: Gregory P. Smith <[email protected]>
…he Windows console (pythonGH-124059)

Since MultiByteToWideChar()/WideCharToMultiByte() is not reversible if
the data contains invalid UTF-8 sequences, use binary search to
calculate the number of written bytes from the number of written
characters.

Also fix writing incomplete UTF-8 sequences.

Also fix handling of memory allocation failures.
If the top-most frame is a trampoline frame, skip it.
picnixz and others added 4 commits November 27, 2024 16:42
…122289)

Improve performance of this function by a factor of 1.7x.

Co-authored-by: Barney Gale <[email protected]>
"Generally, mixed-mode arithmetic combining real and complex variables should
be performed directly, not by first coercing the real to complex, lest the sign
of zero be rendered uninformative; the same goes for combinations of pure
imaginary quantities with complex variables." (c) Kahan, W: Branch cuts for
complex elementary functions.

That's why C standards since C99 introduce imaginary types.  This patch
proposes similar extension to the Python language:

    * Added a new subtype (imaginary) of the complex type.  New type
      has few overloaded methods (conjugate() and __getnewargs__()).
    * Complex and imaginary types implement IEC 60559-compatible complex
      arithmetic (as specified by C11 Annex G).
    * Imaginary literals now produce instances of imaginary type.
    * cmath.infj/nanj were changed to be of imaginary type.
    * Modules ast, code, copy, marshal got support for imaginary type.
    * Few tests adapted to use complex, instead of imaginary literals
      - Lib/test/test_fractions.py
      - Lib/test/test_socket.py
      - Lib/test/test_str.py
    * Print dot for signed zeros in the real part of repr(complex):

          >>> complex(-0.0, 1)  # was (-0+1j)
          (-0.0+1j)

    * repr(complex) naw prints real part even if it's zero.

Lets consider (actually interrelated) problems, shown for unpatched
code, which will be solved on this way.

1) New code allows to use complex arithmetic for implementation of
   mathematical functions without special "corner cases".  Take the inverse
   tangent as an example:

       >>> z = complex(-0.0, 2)
       >>> cmath.atan(z)
       (-1.5707963267948966+0.5493061443340549j)
       >>> # real part was wrong:
       >>> 1j*(cmath.log(1 - 1j*z) - cmath.log(1 + 1j*z))/2
       (1.5707963267948966+0.5493061443340549j)

2) Previously, we have only unsigned imaginary literals with the following
   semantics:

       ±a±bj = complex(±float(a), 0.0) ± complex(0.0, float(b))

   While this behaviour was well documented, most users would expect
   instead here:

       ±a±bj = complex(±float(a), ±float(b))

   i.e. that it follows to the rectangular notation for complex numbers.

   For example:

       >>> -0.0+1j  # now (-0.0+1j)
       1j
       >>> float('inf')*1j  # now infj
       (nan+infj)

3) The ``eval(repr(x)) == x`` invariant was broken for the complex type:

       >>> complex(-0.0, 1.0)  # also note funny signed integer zero below
       (-0+1j)
       >>> -0+1j
       1j
       >>> complex(0.0, -cmath.inf)
       -infj
       >>> -cmath.infj
       (-0-infj)
@skirpichev skirpichev force-pushed the imaginary-class-109218 branch from d56a55c to d062169 Compare November 28, 2024 02:24
encukou and others added 6 commits November 28, 2024 13:29
… process (pythonGH-127331)

- Add `git describe` output to headers generated by `make_ssl_data.py`

  This info is more important than the date when the file was generated.
  It does mean that the tool now requires a Git checkout of OpenSSL,
  not for example a release tarball.

- Regenerate the older file to add the info.
  To the other older file, add a note about manual edits.

- Add notes on how to add a new OpenSSL version

- Add 3.4 error messages and multissl tests
Reformat paragraphs, add backquotes, and directives.
Don't make the assumption that the 'name' argument is a string. Use
repr() to format the 'name' argument instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.