Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide xml-query.el as a separate package #189

Closed
marsam opened this issue Jan 11, 2017 · 5 comments
Closed

Provide xml-query.el as a separate package #189

marsam opened this issue Jan 11, 2017 · 5 comments

Comments

@marsam
Copy link

marsam commented Jan 11, 2017

Hi:
Thanks for your work in elfeed. Would you mind releasing xml-query.el as a separate package in melpa. I really think the Emacs ecosystem would benefit from this package.

Thanks in advance!

@skeeto
Copy link
Owner

skeeto commented Jan 16, 2017 via email

@marsam
Copy link
Author

marsam commented Feb 2, 2017

Hi:

Sorry for the late response.

  1. Elfeed has no dependencies outside of Emacs. This is incredibly convenient
    for development, testing, and stability -- so much so that I've become very
    hesitant to have any dependencies in any of my packages. Putting xml-query
    on Melpa would essentially mean moving it out of Elfeed and making it a
    dependency.

I think this can be solved separating the melpa recipe

  • current

    (elfeed :repo "skeeto/elfeed"
            :fetcher github)
  • New recipes

    (elfeed :repo "skeeto/elfeed"
            :fetcher github
            :files (:defaults
                    (:exclude "xml-query.el")))
    (xml-query :repo "skeeto/elfeed"
               :fetcher github
               :files ("xml-query.el"))

This approach is used by ivy recipe to maintain swiper and counsel as separated packages.

If you like this idea I can make a pull request to melpa with the new recipes.

Do you have a particular use in mind?

Nothing in particular, I just want to use xml-query.el for interacting with
xml based services.

@skeeto
Copy link
Owner

skeeto commented Feb 7, 2017 via email

@alphapapa
Copy link
Contributor

alphapapa commented Sep 5, 2017

Curious, is there any reason to proceed with this? I just experimented with esxml-query, and it works very well, so is there any benefit that this library could provide over it?

Well, I guess the macros would be faster when using hard-coded selectors, right? Maybe that could be added to esxml-query? =)

Thanks.

@skeeto
Copy link
Owner

skeeto commented Sep 7, 2017

@alphapapa You're right. Now that esxml exists, I'd rather people rely on that package instead of a subset of Elfeed. It doesn't (yet?) have the cool compile-to-byte-code stuff, but it's always going to be more feature-complete. I don't want to add any features to xml-query unless Elfeed needs it.

So I'm just going to close this and say, "Use esxml."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants