Skip to content

Commit 20d8d12

Browse files
committed
Update webmock to work on ruby 2.4+
I got lots of this: 1) Cronitor sets its config correctly has the specified options Failure/Error: response = Unirest.get( "#{API_URL}/monitors/#{URI.escape(name).gsub('[', '%5B').gsub(']', '%5D')}", headers: default_headers, auth: { user: token } ) NoMethodError: undefined method `close' for #<StubSocket:0x007f8de75d28a8> # ./lib/cronitor.rb:46:in `exists?' # ./lib/cronitor.rb:27:in `initialize' # ./spec/cronitor_spec.rb:17:in `new' # ./spec/cronitor_spec.rb:17:in `block (3 levels) in <top (required)>' # ./spec/cronitor_spec.rb:25:in `block (3 levels) in <top (required)>' # ------------------ # --- Caused by: --- # RestClient::ResourceNotFound: # 404 Resource Not Found # ./lib/cronitor.rb:46:in `exists?' Seems to be this issue which is fixed in webmock >= 2.3.1: bblimke/webmock#683 Simply updating seems to work fine.
1 parent e6d7869 commit 20d8d12

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

cronitor.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
2525
spec.add_development_dependency 'rake', '~> 10.0'
2626
spec.add_development_dependency 'rspec', '~> 3.3'
2727
spec.add_development_dependency 'pry', '~> 0.10'
28-
spec.add_development_dependency 'webmock', '~> 1.21'
28+
spec.add_development_dependency 'webmock', '~> 2.3', '>= 2.3.1'
2929
spec.add_development_dependency 'sinatra', '~> 1.4'
3030
spec.add_development_dependency 'bump', '~> 0.1'
3131
end

0 commit comments

Comments
 (0)