Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple pages navigation #29

Closed
soulgalore opened this issue Oct 30, 2018 · 2 comments
Closed

Support multiple pages navigation #29

soulgalore opened this issue Oct 30, 2018 · 2 comments

Comments

@soulgalore
Copy link
Member

When we navigate to two different pages (using Browsertime) we still just create one page (branch with example trace https://github.com/sitespeedio/chrome-har/tree/multi-page-har).

The problem is that we use the frame_id as the unique key when we create a page new page. But the frame_id is the same between navigation, so when we get new requests, we match that with the first page.

@rriemann
Copy link

How is this issue linked to #19 ?

@soulgalore
Copy link
Member Author

Ohh this one is old, I think we actually skipped it and create one trace per navigation that makes it so much simpler. For #19 seems to be a puppeteer issue, I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants