Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly (sync) created thumbnail don't get optimized. #9

Closed
dlubitz opened this issue Jan 23, 2025 · 4 comments · Fixed by #10
Closed

Newly (sync) created thumbnail don't get optimized. #9

dlubitz opened this issue Jan 23, 2025 · 4 comments · Fixed by #10

Comments

@dlubitz
Copy link

dlubitz commented Jan 23, 2025

Due to the change from using the Aspect to the Signal/Slot some cases don't get handled anymore.

When I try to get a new thumbnail syncronous, which does not exist in database yet, the thumbnailRefreshed signal is not sent. So no optimization will be applied.

Before the change the aspect set around Thumbnail->refresh()

See: 96436b1

But the signal thumbnailRefreshed covers this just partially, as Thumbnail::initializeObject also calls Thumbnail->refresh() without sending the signal.

https://github.com/neos/neos-development-collection/blob/8.3/Neos.Media/Classes/Domain/Model/Thumbnail.php#L107-L114

https://github.com/neos/neos-development-collection/blob/8.3/Neos.Media/Classes/Domain/Service/ThumbnailService.php#L148-L164

@mficzel
Copy link
Member

mficzel commented Jan 28, 2025

Will revert to the aspect ... this is annoying.

@dlubitz
Copy link
Author

dlubitz commented Jan 28, 2025

I also tried different things, to work around. But nothing worked.

@mficzel
Copy link
Member

mficzel commented Jan 28, 2025

@dlubitz ... give 2.1.0 a shot ... also added phpcs + phpstan

@dlubitz
Copy link
Author

dlubitz commented Jan 28, 2025

Works like charm! Thank you for taking care @mficzel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants