Manually created block landmarks

[SettingDust]

When working on https://github.com/SettingDust/SurveyorAtlases.
I noticed the Moonlight has the block marker that can mark the block by right-clicking the block with the map.
For structures, I can get the marker type from the structure https://github.com/SettingDust/SurveyorAtlases/blob/main/src/main/kotlin/settingdust/surveyor_atlases/SurveyorStructureDecoration.kt#L36

But for blocks. I have to mapping them manually https://github.com/SettingDust/SurveyorAtlases/blob/main/src/main/kotlin/settingdust/surveyor_atlases/SurveyorLandmarkDecoration.kt#L129-L186

How about a data driven generic marker for blocks like how POI?
If the block discovering has heavy performance impact. How about data driven block entity marker since there is index?

https://modrinth.com/mod/block-swap is able to replace the blocks. So I think block discoverer is possible as well.

[sisby-folk]

This is interesting and seems like a nice command or something - what does this look like in map atlases? Does it use the block item model?

[SettingDust]

It's provided by resource pack
https://github.com/MehVahdJukaar/Supplementaries/blob/master/common/src/main/resources/data/supplementaries/moonlight/map_markers/bell.json
https://github.com/MehVahdJukaar/Supplementaries/blob/master/common/src/main/resources/assets/supplementaries/textures/map_marker/bell.png

[sisby-folk]

So is the idea that the landmark signifies a block being at a specific location, and then the block is broken the landmark is invalidated?

[SettingDust]

So is the idea that the landmark signifies a block being at a specific location, and then the block is broken the landmark is invalidated?

I think so. It won't disappear in Moonlight. Since it's marked manually.