Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Palette OOB Crash #46

Open
DaPuffer opened this issue Aug 8, 2024 · 6 comments
Open

Block Palette OOB Crash #46

DaPuffer opened this issue Aug 8, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@DaPuffer
Copy link

DaPuffer commented Aug 8, 2024

Mc version-1.20.1. Surveyor embedded in antique-atlas-2.9.13+1.20 version. Forge,Sinytra connector.
I created a world,tried to remove a mod, tried to join the world afterwards and the game crashed on world loading at 0%.
crash-2024-08-08_16.15.17-client.txt
Tested with removing different mods and here's the results:
Exposure:No crash
Backpacked:Crash
CreateDreams&Desires:Crash
Infinity buttons:Crash
Supplementaries:Crash
really weird

@sisby-folk sisby-folk added the bug Something isn't working label Aug 9, 2024
@sisby-folk sisby-folk changed the title Crash on world loading after removing some mods Block palette crash after uninstalling mods that add blocks Aug 9, 2024
@sisby-folk
Copy link
Owner

Thank you for this! I've been looking for a strong reproduction case for this issue and "uninstalling a mod that adds blocks" looks like it's right

@DaPuffer
Copy link
Author

DaPuffer commented Aug 9, 2024

Thank you for this! I've been looking for a strong reproduction case for this issue and "uninstalling a mod that adds blocks" looks like it's right

The weird thing is that exposure does add a block. A single one- the lightroom,but it does not cause any issues

@sisby-folk
Copy link
Owner

that still makes sense - the block has to be both in the world, and in the position / having the properties that would cause it to be stored on the map (e. g. has map color, on surface)

@sisby-folk
Copy link
Owner

I am struggling to reproduce this even after i was sure this was the cause - I just generated a singleplayer world with BWG, removed BWG, and it ran:

image
image

very proud of my repaletting code here as it seems to be doing great. Raises the question of when does this not work. Going to try some of the above listed mods.

@sisby-folk
Copy link
Owner

sisby-folk commented Oct 16, 2024

this is the underlying issue for sisby-folk/antique-atlas#208 of course, for which all current reports appear to be on forge 1.20 so i might try that specifically - here's the three logs:

https://mclo.gs/AnznANw

https://mclo.gs/QLTrFqi

https://mclo.gs/hErwTm4

first two are in multiplayer though, which was my other clue - not sure.

@sisby-folk
Copy link
Owner

forge 1.21 with BOP and supplementaries, multiplayer.

Fine, placing some supplementaries blocks and then removing supplementaries, also fine:

image

deleting client-side map data and then reconnecting: also fine.

Genuinely, no idea how to reproduce this.

@sisby-folk sisby-folk changed the title Block palette crash after uninstalling mods that add blocks Block Palette OOB Crash Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants