Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landmark Fallback Typing #14

Open
sisby-folk opened this issue Apr 1, 2024 · 1 comment
Open

Landmark Fallback Typing #14

sisby-folk opened this issue Apr 1, 2024 · 1 comment
Labels
enhancement New feature or request landmarks Related to the landmark system

Comments

@sisby-folk
Copy link
Owner

sisby-folk commented Apr 1, 2024

Landmark classes should contain a method that returns a "fallback landmark"

This defaults to creating a SimplePointLandmark from the available fields.

Simple landmark types should have a nullable "originalType" ID field where the actual type of the landmark can be inserted.

These should be networked whenever landmarks are networked - and taken when the other doesn't exist.

@sisby-folk sisby-folk added enhancement New feature or request landmarks Related to the landmark system labels Apr 1, 2024
@sisby-folk
Copy link
Owner Author

sisby-folk commented Apr 28, 2024

might be worth storing the full NBT of the unknown landmark? that way a client-side landmark could appear in-full on multiple clients when shared. (a bit insecure though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request landmarks Related to the landmark system
Projects
None yet
Development

No branches or pull requests

1 participant