fix race condition caused by writing to entry.Data #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chnique as JSONFormatter
h12w
changed the title
dgsb
reviewed
Nov 6, 2018
dgsb
reviewed
Nov 6, 2018
text_formatter.go
Outdated
| @@ -160,7 +163,7 @@ func (f *TextFormatter) Format(entry *Entry) ([]byte, error) { | |||
| timestampFormat = defaultTimestampFormat | |||
| } | |||
| if f.isColored() { | |||
| f.printColored(b, entry, keys, timestampFormat) | |||
| f.printColored(b, entry, keys, nil, timestampFormat) | |||
There was a problem hiding this comment.
Should we give the new data array as parameter here ?
cgxxv
pushed a commit
to cgxxv/logrus
that referenced
this pull request
Mar 25, 2022
fix race condition caused by writing to entry.Data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be able to fix #468, and it uses the same technique as JSONFormatter.