Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there are errors for generated javascript files when "package" field does not exist #5

Open
enginespot opened this issue Jan 25, 2013 · 1 comment

Comments

@enginespot
Copy link

for pbj file , if I delete the line

"package ProtoJSTest.PB;"

for the generated file :"Test.pbj.js"

there are many javascript errors

@SteveBaker
Copy link

I'm seeing something similar/related.

If the AAA.proto file includes

import "BBB.proto"
package xxx.yyy ;
message AAA
{
optional BBB bbb ;
....
}

...and BBB.proto contains:

package xxx.yyy ;
message BBB
{
....
}

Then protojs generates:

bbb: {
...
type: function () { return bbb ; }
}

...which causes JavaScript to say that 'bbb' is undefined.

ProtoJS SHOULD generate:

bbb: {
...
type: function () { return xxx.yyy.bbb ; }
}

...if I manually make that change then the system works just great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants