Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deactivated athena accounts #11

Open
1 task done
celskeggs opened this issue Feb 9, 2020 · 5 comments
Open
1 task done

Remove deactivated athena accounts #11

celskeggs opened this issue Feb 9, 2020 · 5 comments
Labels
bug Something isn't working P4 priority 4

Comments

@celskeggs
Copy link
Member

celskeggs commented Feb 9, 2020

  • also figure out how to handle external email accounts
@gabrc52
Copy link
Contributor

gabrc52 commented Jan 8, 2023

External email address issue moved to #17

It would also be nice to sync people's names to avoid accidentally leaving people's deadnames (people have permission to change their own names, but name change events appear in the room history)

@gabrc52 gabrc52 added the P4 priority 4 label Jan 9, 2023
@gabrc52
Copy link
Contributor

gabrc52 commented Jan 9, 2023

Hmmm, but when you deactivate a Matrix ID the localpart (username) is reserved forever. So would have to think of a good solution, because that's not how it works with kerbs. Also, if we're not careful and don't do this, people might inherit accounts from someone who used to have their same kerb.

@gabrc52
Copy link
Contributor

gabrc52 commented Jan 9, 2023

Actually, I think leaving the account deactivated would work fine, because then if someone else has my same kerb (rgabriel), they would have the account rgabriel1, and the accounts would be separate. The important step is removing the SSO account so that they don't inherit my account.

@gabrc52 gabrc52 added the bug Something isn't working label Jan 9, 2023
@gabrc52
Copy link
Contributor

gabrc52 commented Jan 11, 2023

So 2 things that can be done together:

Hmm, for this and the moira list integration the best option might be to have a cronjob that runs every hour (or another appropriate amount of time) and checks for people's mailing lists, invites them to the right rooms if they are not in them, and checks if the account still exists. If we persist some state from moira queries, we can also check if their display name was synced to their moira name and is still set to that but their moira name changed, update their display name accordingly. So 2 things here:

  • automatically change display name when moira display name changes (related to Think about usernames and display names #22) (ideally redact old display name events, or can do this on request)
  • automatically deactivate an account if the account is deactivated

@gabrc52
Copy link
Contributor

gabrc52 commented Jan 16, 2023

Hmmm also the SSO uid is currently set to the email, maybe we can use the Unix/Athena uid instead to prevent the issue when someone reuses someone else's kerb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P4 priority 4
Projects
None yet
Development

No branches or pull requests

2 participants