Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spire virt auto launch should not scan for supervisor keys #497

Open
celskeggs opened this issue Feb 29, 2020 · 3 comments
Open

spire virt auto launch should not scan for supervisor keys #497

celskeggs opened this issue Feb 29, 2020 · 3 comments

Comments

@celskeggs
Copy link
Member

The code used in spire virt auto install to make sure we have the right keys for the supervisor node is not needed -- and, in fact, is actively unwanted -- during launches of existing clusters.

We should change spire so that this code is only used when it's needed.

@cryslith
Copy link
Member

I don't quite understand - why does the ssh command succeed during install but fail during a subsequent launch?

@celskeggs
Copy link
Member Author

I'm not entirely sure off the top of my head why it fails, but the reason we shouldn't need this is that, after the first launch, we should have everything we need set up to authenticate correctly without checking the hostkey via the MOTD fingerprint.

@cryslith
Copy link
Member

cryslith commented Apr 17, 2020

Additional context from meeting: it subsequently fails because we intentionally shift aside old authorized_keys after we set up the supervisor's final ssh configuration. So that part is intended behavior.

@cryslith cryslith self-assigned this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants