Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "make check" #6

Open
practicalswift opened this issue Aug 28, 2019 · 3 comments
Open

Missing "make check" #6

practicalswift opened this issue Aug 28, 2019 · 3 comments

Comments

@practicalswift
Copy link
Contributor

Missing make check.

make check would simply run the test suite (miniscript_tests.cpp) :-)

@sipa
Copy link
Owner

sipa commented Aug 28, 2019

That won't work; the tests rely on the rest of the Bitcoin Core source code.

@practicalswift
Copy link
Contributor Author

@sipa Perhaps a short note on how to setup the project (including fetching a copy of the Bitcoin Core source code) to make testing miniscript easy would be enough?

@practicalswift
Copy link
Contributor Author

Perhaps an alternative would be to add a new smaller test suite that doesn't depend on the rest of the Bitcoin Core source code and would be runnable as make check out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants