Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling node->ToString on a node constructed from 2000 consecutive OP_FALSE opcodes causes execution to halt due to running out of stack space #15

Open
practicalswift opened this issue Sep 12, 2019 · 1 comment
Open

Calling node->ToString on a node constructed from 2000 consecutive OP_FALSE opcodes causes execution to halt due to running out of stack space #15

practicalswift opened this issue Sep 12, 2019 · 1 comment

Comments

@practicalswift
Copy link
Contributor

practicalswift commented Sep 12, 2019 •
edited
Loading

Calling node->ToString on a node constructed from 2000 consecutive OP_FALSE opcodes causes execution to halt due to running out of stack space.

The root cause is the unbounded recursion in MakeString.
@sipa
Copy link
Owner

sipa commented Sep 12, 2019

@practicalswift Yeah, I pointed this out here: #5 (comment) actually. We need recursion limits in FromScript as well as FromString.

@practicalswift practicalswift mentioned this issue Sep 8, 2020
Closed
@practicalswift practicalswift mentioned this issue Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sipa @practicalswift