Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the meaning of variable "clientVersion"? #73

Open
ccconnor opened this issue Mar 20, 2019 · 0 comments
Open

What's the meaning of variable "clientVersion"? #73

ccconnor opened this issue Mar 20, 2019 · 0 comments

Comments

@ccconnor
Copy link

The variable "clientVersion" is compared with REQUIRE_VERSION(which is a protocol version) in the function IsGood,

if (clientVersion && clientVersion < REQUIRE_VERSION) return false;

while it is compared with 31900(which seems to be a client version v0.3.19) in the function GetBanTime.

if (clientVersion && clientVersion < 31900) { return 604800; }

I'm confused. What on earth should "clientVersion" be compared with? Client version or protocol version?
This is the output of bitcoin-cli.

$ bitcoin-cli getnetworkinfo
{
  "version": 170100,
  "subversion": "/Satoshi:0.17.1/",
  "protocolversion": 70015,
......
}

Looking forward reply. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant