Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds possibility to specify batch_norm, bias and batch_norm_scale for each layer #217

Merged
merged 8 commits into from
Feb 15, 2024

Conversation

MaxFBurg
Copy link
Member

To specify batch norm and its properties for each layer individually, this PR changes the attributes batch_norm bias batch_norm_scale and the according class members to lists.

Backwards-compatibility is ensured.

Also includes #215 which should be merged first.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (d66f372) 7.35% compared to head (3c0c412) 7.38%.

Files Patch % Lines
neuralpredictors/layers/cores/conv2d.py 36.66% 15 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #217      +/-   ##
========================================
+ Coverage   7.35%   7.38%   +0.02%     
========================================
  Files         58      58              
  Lines       5939    5947       +8     
  Branches    1005    1006       +1     
========================================
+ Hits         437     439       +2     
- Misses      5473    5478       +5     
- Partials      29      30       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KonstantinWilleke
Copy link
Contributor

Thanks a lot Max! I've built that branch with the sensorium model and tried it out - worked as intended.

@KonstantinWilleke
Copy link
Contributor

The branch is out of date with the base branch though - could you update it? then I'll go ahead and merge

@MaxFBurg
Copy link
Member Author

MaxFBurg commented Feb 15, 2024

Thank you @KonstantinWilleke ! Merged the latest changes from main, so this PR should now be ready for merging into main.

@MaxFBurg MaxFBurg merged commit 29206ec into sinzlab:main Feb 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants