Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-built v4.1.5 uses old version of nise #1656

Closed
tzrh opened this issue Jan 16, 2018 · 5 comments
Closed

Pre-built v4.1.5 uses old version of nise #1656

tzrh opened this issue Jan 16, 2018 · 5 comments
Assignees
Labels

Comments

@tzrh
Copy link
Contributor

tzrh commented Jan 16, 2018

What did you expect to happen? / What actually happens

The build of sinon at http://sinonjs.org/releases/sinon-4.1.5.js should be built with nise v1.2.0, but is somehow being built with an earlier version of nise. The same applies to sinon/pkg/sinon.js when installing sinon v4.1.5 locally using npm.

How to reproduce

Note that http://sinonjs.org/releases/sinon-4.1.5.js doesn't include the changes from sinonjs/nise@1990dd0#diff-8e958e497c1f86e91539a2fc732ef143 (search for Fake server response body should be string). Earlier versions of sinon (e.g. v4.1.4) do include the change.

@mroderick mroderick self-assigned this Jan 16, 2018
@mroderick
Copy link
Member

Thank you for the very precise error report 👌

I've published [email protected] to npm, and have deprecated [email protected].

Could you verify the fix on your end and if confirmed, close this issue?

@mroderick mroderick added the Bug label Jan 16, 2018
@mroderick
Copy link
Member

Background

This issue was caused by an error on my part, as I forgot to run npm install after fetching master for the [email protected] release, which was released after #1534 was merged.

@mroderick
Copy link
Member

I have published sinon-5.0.0-next.3 with a fresh build including the changes from [email protected] as sinon@next

@tzrh
Copy link
Contributor Author

tzrh commented Jan 17, 2018

Thanks for the quick reply, v4.1.6 looks fine!

@tzrh tzrh closed this as completed Jan 17, 2018
@mroderick
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants