Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #483 and jestjs/jest#14549 #485

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented Oct 19, 2023

Purpose (TL;DR) - mandatory

Fix the async time forwarders that seemed to not run enqueued micro-tasks.

Background (Problem in detail) - optional

See #483 for details

I will move the tests around, as they were used to just verify the original issue. Posting the draft here.

@fatso83 fatso83 marked this pull request as draft October 19, 2023 18:57
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6ef392) 96.48% compared to head (25dc957) 96.49%.

❗ Current head 25dc957 differs from pull request most recent head 8b16f52. Consider uploading reports for the commit 8b16f52 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
+ Coverage   96.48%   96.49%   +0.01%     
==========================================
  Files           2        2              
  Lines         682      684       +2     
==========================================
+ Hits          658      660       +2     
  Misses         24       24              
Flag Coverage Δ
unit 96.49% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/fake-timers-src.js 96.51% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@fatso83 fatso83 merged commit 5e347dc into sinonjs:main Oct 20, 2023
9 checks passed
@fatso83 fatso83 deleted the async-issues-run-all-fix branch October 20, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants