Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added working with timseries data notebook #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KSNidhi-2000
Copy link

added a new notebook on timeseries data for spaces

Copy link
Collaborator

@kesmit13 kesmit13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run the pre-commit checks to format the notebook and run checks on the meta.toml (I see that it's missing the icon field). See https://github.com/singlestore-labs/spaces-notebooks/blob/master/CONTRIBUTING.md.

As for the notebook itself:

  1. Add a paragraph or two at the top describing what the notebook does.

  2. You should use uppercase for all SQL keywords. The casing is inconsistent.

  3. Don't use use time_series. See one of the getting started notebooks that have a note about selecting time_series from the database selector in the notebook interface. This ensures that all new connections use that database.

  4. I think you are missing some %%sqls is some cells. See In[38] and a few after that one.

  5. Make sure you are selecting Markdown as the cell type if typing documentation. I see a few blocks of documentation that are in code cells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants