Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plus addressing breaks e-mail address verification #262

Open
RokeJulianLockhart opened this issue Jun 27, 2023 · 5 comments
Open

Plus addressing breaks e-mail address verification #262

RokeJulianLockhart opened this issue Jun 27, 2023 · 5 comments

Comments

@RokeJulianLockhart
Copy link

I attempted to register using [email protected]. When I received the code, clicking the verify button didn't work. I was about to consider this a problem with my browser, but when I tried to click the e-mailed link instead, the consequent page (https://app.singlelink.co/[email protected]&code=145330&newSignup=true) appeared to depict my address incorrect sanitized in some manner:

image

@RokeJulianLockhart
Copy link
Author

Indeed, plus addressing is the problem - [email protected] works. Remember when implementing e-mail dependent registration that you read the entirety of the relevant RFCs or use a well-tested library.

@RokeJulianLockhart RokeJulianLockhart changed the title Unable to verify e-mail address Plus addressing breaks e-mail address verification Jun 27, 2023
@saraspaudel
Copy link
Member

I believe this was initially implemented to prevent bot signups.

@RokeJulianLockhart
Copy link
Author

I think that that's an ineffective solution since I quite easily bypassed it using AnonAddy, but you could at least notify the user and not send the e-mail message until the sub address is removed.

@ciroiriarte
Copy link

I would also normally use plus addressing. Please consider adding support for it.

@RokeJulianLockhart

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants