Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Update Scene add_* methods #236

Merged
merged 6 commits into from
Oct 16, 2024
Merged

[python] Update Scene add_* methods #236

merged 6 commits into from
Oct 16, 2024

Commits on Oct 16, 2024

  1. Update Scene add_* methods 

    * Rename `add_*` -> `add_new_*` for consistency with `Collection`
  methods.
* Change type specific keywords to be `**kwargs` and refer to class
  create methods for specific keywords.
    @jp-dark
    jp-dark committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3322f13 View commit details
    Browse the repository at this point in the history

  2. Remove platform_config from Scene add_new_* methods 

    This parameter is already a keyword arugment in the spatial `create`
methods.
    @jp-dark
    jp-dark committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    98d8b38 View commit details
    Browse the repository at this point in the history

  3. Change examples in docs to be things that go in varl

    @jp-dark
    jp-dark committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4a49dcb View commit details
    Browse the repository at this point in the history

  4. Fix typo in docstring

    @jp-dark
    jp-dark committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    20680fa View commit details
    Browse the repository at this point in the history

  5. Make transform a kwarg and fix more docstrings

    @jp-dark
    jp-dark committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    accb814 View commit details
    Browse the repository at this point in the history

  6. Update args docstring order to match method definition

    @jp-dark
    jp-dark committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4126d4b View commit details
    Browse the repository at this point in the history