CI version bumps, deps factor #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-williams
force-pushed
the
rw/gha
branch
from
e45007f to
6588da1
Compare
ryan-williams
force-pushed
the
rw/gha
branch
from
6588da1 to
24a50f7
Compare
ryan-williams
commented
Sep 23, 2024
| run: | | ||
| pip install -r python-spec/requirements-py${{ env.PYTHON_VERSION }}-lint.txt | ||
| working-directory: python-spec | ||
| run: pip install -r requirements-py${PYTHON_VERSION}.txt -r requirements-py${PYTHON_VERSION}-lint.txt |
There was a problem hiding this comment.
#224 also makes this change, either one can be merged first
Merged
johnkerl
approved these changes
Sep 23, 2024
|
See also single-cell-data/TileDB-SOMA#2141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requirements-py3.8-lint.txtrepeated all the deps fromrequirements-py3.8.txt; here I've removed those common deps from the former, and install/cache based on both files in GHA. This was motivated by dropping Python 3.8 (#224), where I wanted to audit (and upgrade pins for) the lint-only deps.Also bumped:
actions/checkout:v3→v4actions/setup-python:v4→v5single-cell-data/TileDB-SOMA#2141
sc-41048