-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spatial presence matrices #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor nits, but otherwise 👍
149bea1
to
12eec91
Compare
160585d
to
4019c15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor comments but still good to go.
This adds dataframes for creating a join table between the scenes and observations/variables. New methods are added to the `ExperimentAxisQuery` class for getting a Arrow array of scene names that relate to the obs or var in the query.
4019c15
to
f2a025e
Compare
Co-authored-by: Aaron Wolen <[email protected]>
[sc-50286] |
This adds dataframes for creating a join table between the scenes and observations/variables. New methods are added to the
ExperimentAxisQuery
class for getting a Arrow array of scene names that relate to the obs or var in the query.This PR is ready to be reviewed, but should be merged after PR #220