Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spatial presence matrices #221

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Add spatial presence matrices #221

merged 3 commits into from
Sep 26, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Sep 13, 2024

This adds dataframes for creating a join table between the scenes and observations/variables. New methods are added to the ExperimentAxisQuery class for getting a Arrow array of scene names that relate to the obs or var in the query.

This PR is ready to be reviewed, but should be merged after PR #220

Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor nits, but otherwise 👍

Copy link

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments but still good to go.

python-spec/src/somacore/measurement.py Outdated Show resolved Hide resolved
python-spec/src/somacore/experiment.py Outdated Show resolved Hide resolved
python-spec/src/somacore/experiment.py Outdated Show resolved Hide resolved
Base automatically changed from dark/scene to main September 26, 2024 17:56
This adds dataframes for creating a join table between the scenes and
observations/variables. New methods are added to the
`ExperimentAxisQuery` class for getting a Arrow array of scene names
that relate to the obs or var in the query.
@jp-dark jp-dark force-pushed the dark/spatial-presence branch from 4019c15 to f2a025e Compare September 26, 2024 17:59
@jp-dark jp-dark marked this pull request as ready for review September 26, 2024 18:00
@jp-dark jp-dark merged commit 73ccc06 into main Sep 26, 2024
6 checks passed
@jp-dark jp-dark deleted the dark/spatial-presence branch September 26, 2024 18:03
@jp-dark
Copy link
Collaborator Author

jp-dark commented Sep 26, 2024

[sc-50286]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants