Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classes for coordinate spaces and transforms #218

Merged
merged 25 commits into from
Sep 18, 2024
Merged

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    b02dd45 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    ff532b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cbaa95f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a2b3c1f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    75e77d6 View commit details
    Browse the repository at this point in the history
  5. Add lifecycle to docstrings

    jp-dark committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    36ae037 View commit details
    Browse the repository at this point in the history
  6. Remove redundant rank methods

    jp-dark committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e4ec1f6 View commit details
    Browse the repository at this point in the history
  7. Change RuntimeError -> ValueError

    - PR feedback
    jp-dark committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    fa4918e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    40cbe3a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8148c1a View commit details
    Browse the repository at this point in the history
  10. Adjust names and docstrings

    jp-dark committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    afe2e54 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Update coordinate class based on feedback

    - Drop scale from units
    - Use `attrs` instead of `dataclass`
    - Remove ABC meta class (bug)
    jp-dark committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9c514cd View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Run linters

    jp-dark committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0b63287 View commit details
    Browse the repository at this point in the history
  2. Update attrs usage based on PR feedback

    - Add docstrings to Axis
    - Use `attrs` for CoordinateSpace
    - Add helper function for validation
    jp-dark committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    99d5df2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    79de67f View commit details
    Browse the repository at this point in the history
  4. Improve CoordinateSpace inheritance based on PR feedback

    Make CoordinateSpace classes call the super.__init__ from the level
    above.
    jp-dark committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    893b34e View commit details
    Browse the repository at this point in the history
  5. Fix typo python-spec/src/somacore/types.py

    Co-authored-by: paul fisher <[email protected]>
    jp-dark and thetorpedodog authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7350d2a View commit details
    Browse the repository at this point in the history
  6. Add helper methods for checking axes for @ based on PR feedback

    Add new methods that throw value errors for mismatched axes with a
    more meaningful error message.
    jp-dark committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7deb1e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Fix error messages

    jp-dark committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d63117f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    509a462 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    64b1362 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7365f37 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6bcec59 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b896712 View commit details
    Browse the repository at this point in the history
  7. Fix 3.8 type error

    jp-dark committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ff235d0 View commit details
    Browse the repository at this point in the history