Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit linters and new lint errors #207

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Jul 31, 2024

Update linter versions, set target Python version for linters to Python 3.8, and address new linter errors.

Lint fixes:

  • Add pandas stub
  • Remove call to deprecated pd.api.types.is_categorical_dtype
  • Add type annotation for numpy array variable
  • Update pyproject.toml ruff syntax
  • Black format changes

* Black format changes
* Remove call to deprecated `pd.api.types.is_categorical_dtype`
* Update pyproject.toml ruff syntax
@jp-dark jp-dark requested review from bkmartinjr and johnkerl July 31, 2024 17:24
Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two suggestions related to testing for python 3.8 compat code. Otherwise LGTM

@jp-dark jp-dark requested a review from bkmartinjr July 31, 2024 17:46
@jp-dark jp-dark merged commit e5a28c6 into main Jul 31, 2024
7 checks passed
@jp-dark jp-dark deleted the dark/update-pre-commit-versions branch July 31, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants