-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type-check Pandas code and require newer pyarrow. #201
Conversation
thetorpedodog
commented
Jun 17, 2024
- Pandas now has canonical type stubs, which mypy can find and install.
- We no longer support py3.7, so we don't need the pyarrow hotfix.
- Type annotation fix related to installing Pandas stubs.
0a65b54
to
14af645
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer support py3.7, so we don't need the pyarrow hotfix.
@thetorpedodog this is a longer story -- we don't need the hotfix as long as we've got pyarrow >= 14
But here is the current status on that, which is not done yet:
- [python] Try 3.12 again [WIP] TileDB-SOMA#2692
- [Python] AWS SDK 1.11 support in pyarrow wheels? apache/arrow#42154 (comment)
This is confusing, so to be extra-clear here:
- On MacOS, there is a fatal error unless pyarrow < 13
- We've lived that way for a while
- Trying to have TileDB-SOMA support Python 3.12 ([python] Try 3.12 again [WIP] TileDB-SOMA#2692) -- is blocked since pyarrow < 13 doesn't exist with Python 3.12
- This has also, separately, impacted the attempted TileDB-SOMA 1.12 release tiledbsoma 1.12.0 pre-check TileDB-Inc/tiledbsoma-feedstock#171 but in a way which has been worked around for now.
TL;DR -- we need pyarrow-hotfix
for now. And I'll deal with this, once all the above issues are resolved, on single-cell-data/TileDB-SOMA#1926
@@ -16,12 +16,9 @@ dependencies = [ | |||
"numba", | |||
"numpy>=1.21", | |||
"pandas", | |||
"pyarrow", | |||
# TODO: once we no longer support Python 3.7, remove this and pin to pyarrow >= 14.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following on from my review comment: let's keep pyarrow-hotfix
and update the reason-why-it-is-needed comment (which has gone stale)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyarrow-hotfix has been restored.
To do this, I (after some trial and error):
|
- Pandas now has canonical type stubs, which mypy can find and install. - Type annotation fix related to installing Pandas stubs. - Update commentary on why we still use pyarrow-hotfix.
14af645
to
2fedc03
Compare