Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Use _index_factory in AxisIndexer class #189

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Mar 20, 2024

Replace pd.Index with the user provided _index_factory when construction the cached var/obs indices.

@jp-dark jp-dark requested a review from thetorpedodog March 20, 2024 21:11
Copy link
Contributor

@thetorpedodog thetorpedodog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor things that I think are technically only relevant to static analysis. It is probably worth running a tiledbsoma pipeline with the somacore dep pointed at this change to make sure it works end-to-end.

python-spec/src/somacore/query/query.py Outdated Show resolved Hide resolved
python-spec/src/somacore/query/query.py Outdated Show resolved Hide resolved
@jp-dark
Copy link
Collaborator Author

jp-dark commented Mar 21, 2024

It is probably worth running a tiledbsoma pipeline with the somacore dep pointed at this change to make sure it works end-to-end.

Tested this locally and all tests passed.

@jp-dark jp-dark requested a review from thetorpedodog March 21, 2024 17:27
@jp-dark jp-dark merged commit 1f87546 into main Mar 26, 2024
8 checks passed
@jp-dark jp-dark deleted the dark/use_index_factory branch March 26, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants