[python] Make Slice protocol not runtime_checkable
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetorpedodog
force-pushed
the
overbroad-slice-protocol
branch
from
4dbbc1e to
38ad712
Compare
thetorpedodog
changed the title
Slice protocol as abc, not Protocol.Slice protocol not runtime_checkable.
johnkerl
changed the title
Slice protocol not runtime_checkable. Slice protocol not runtime_checkable
|
Update: Since mypy doesn’t currently understand |
Since `range` has the members `start`/`stop`/`step`, that meant that `isinstance(range(x), Slice)` would return True, when a `range` is *not* a `Slice`. Instead, we only provide the `is_slice_of` function (originally from `tiledbsoma`) to perform the appropriate type check. This also unrestricts `Slice`s from being `Comparable`, since the built-in `slice` type does not have this restriction.
thetorpedodog
force-pushed
the
overbroad-slice-protocol
branch
from
38ad712 to
f2c066a
Compare
johnkerl
approved these changes
Feb 15, 2023
thetorpedodog
force-pushed
the
overbroad-slice-protocol
branch
from
a85cc01 to
f2c066a
Compare
|
Oops, had not noticed the approval. Reverting to the approved state (i.e. no longer removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
rangehas the membersstart/stop/step, that meant thatisinstance(range(x), Slice)would return True, when arangeis not aSlice. Usingabcand manually registeringslicefixes this.This also unrestricts
Slices from beingComparable, since the built-inslicetype does not have this restriction, and adds theis_slice_offunction, taken fromtiledbsoma.