Add new supported types and improve precision of coordinates #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes `None` from the `SparseNDCoords` type (since we now accept `()` as the "return everything" value) and separates a singular `SparseNDCoord` type out from it. Also introduces a generic `Slice` protocol, since there is no stdlib-based type annotation for "a slice of a given type". This is, unfortunately, still not useful at runtime, since `slice` is always going to resolve to `Slice[Any]`, but the annotation is useful for specification purposes.
johnkerl
changed the title
johnkerl
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
Nonefrom theSparseNDCoordstype (since we now accept()as the "return everything" value) and separates a singularSparseNDCoordtype out from it.Also introduces a generic
Sliceprotocol, since there is no stdlib-based type annotation for "a slice of a given type". This is, unfortunately, still not useful at runtime, sincesliceis always going to resolve toSlice[Any], but the annotation is useful for specification purposes.This is a roundabout part of fixing single-cell-data/TileDB-SOMA#933.