Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify non-negative soma_joinid in docstring and spec #124

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Clarify non-negative soma_joinid in docstring and spec #124

merged 3 commits into from
Feb 14, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Feb 14, 2023 •
edited
Loading

Described fully at #121

@johnkerl johnkerl mentioned this pull request Feb 14, 2023
Closed
@johnkerl johnkerl marked this pull request as ready for review February 14, 2023 15:21
@johnkerl johnkerl requested a review from bkmartinjr February 14, 2023 15:22
@johnkerl johnkerl changed the title Clarify non-negative soma_joinid in docstring Clarify non-negative soma_joinid in docstring and spec Feb 14, 2023
thetorpedodog
thetorpedodog approved these changes Feb 14, 2023
View reviewed changes
python-spec/src/somacore/data.py Outdated Show resolved Hide resolved
@johnkerl johnkerl merged commit c08df56 into main Feb 14, 2023
@johnkerl johnkerl deleted the kerl/no-negative-jid branch February 14, 2023 16:33
@johnkerl johnkerl mentioned this pull request Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetorpedodog thetorpedodog thetorpedodog approved these changes

@bkmartinjr bkmartinjr bkmartinjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnkerl @bkmartinjr @thetorpedodog