Add support for str and bytes in AxisQuery #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because our backend now supports string and bytes queries [1], we no longer need to reject them at the input stage. Also adds more tests. [1]: single-cell-data/TileDB-SOMA#861
johnkerl
changed the title
johnkerl
approved these changes
Feb 3, 2023
| @@ -28,10 +32,10 @@ def _canonicalize_coords( | |||
| def _canonicalize_coord(coord: options.SparseDFCoord) -> options.SparseDFCoord: | |||
| """Validates a single coordinate, freezing mutable sequences.""" | |||
| if coord is None or isinstance( | |||
| coord, (int, slice, pa.Array, pa.ChunkedArray, np.ndarray) | |||
| coord, (bytes, int, slice, str, pa.Array, pa.ChunkedArray, np.ndarray) | |||
There was a problem hiding this comment.
I considered that, but decided on this since it puts all the built-in types in alphabetical order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because our backend now supports string and bytes queries 1, we no longer need to reject them at the input stage. Also adds more tests.
Related to: single-cell-data/TileDB-SOMA#419