Explicitly use object-identity–based equality for SOMA objects #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inheriting from a type that defines an `__eq__` operation, that `__eq__` will override the built-in `__eq__`. In the case of the `MutableMapping` type, that means that it will try to use element-wise comparison against any other mapping type. This is effectively an attractive nuisance. Instead, we explicitly use the default comparison, which is based on object identity rather than contents or anything.
thetorpedodog
force-pushed
the
eq-and-hash
branch
from
9957d3c to
333aafc
Compare
johnkerl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inheriting from a type that defines an
__eq__operation, that__eq__will override the built-in__eq__. In the case of theMutableMappingtype, that means that it will try to use element-wise comparison against any other mapping type. This is effectively an attractive nuisance. Instead, we explicitly use the default comparison, which is based on object identity rather than contents or anything.