Declare soma_type as a class var rather than a property
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `@property` declarations, the type system would not realize that in the implementation, `soma_type` could always be accessed as a class variable. This change just makes `soma_type` a class var and shuffles around some annotations to make that easier. The `is_sparse` field on `NDArray` is similarly updated.
johnkerl
approved these changes
Jan 26, 2023
johnkerl
changed the title
soma_type as a class var rather than a property.soma_type as a class var rather than a property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
@propertydeclarations, the type system would not realize that in the implementation,soma_typecould always be accessed as a class variable. This change just makessoma_typea class var and shuffles around some annotations to make that easier. Theis_sparsefield onNDArrayis similarly updated.This idea came to me in the shower.