Update package build (and other minor bugs) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code path for when an argument for the catalog is provided doesn't reference the provided catalog. Fixes -- `UnboundLocalError: local variable 'catalog' referenced before assignment`
Issue singer-io#4 - Crash in discovery mode occurs because the PyPi package doesn't contain the metadata path.
Singer utils provide a string from time function that uses DATETIME_FMT_SAFE to prevent 4Y being passed back as the year.
When the catalog is generated in discovery mode, the metadata field that is produced is `tap-criteo.currency`, but when retrieving the metadata, it is looking for `currency`.
|
Hi @kayelow, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @kayelow! Thank you for signing the Singer Contribution License Agreement. |
kayelow
changed the title
|
@cmerrick Hi! I signed the CLA, and it looks like it was received, but let me know if there's anything else you need from me or any feedback you have. |
MobeenAshraf
approved these changes
Aug 6, 2020
|
Hello all ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #4 -- updating the package build to include the metadata files.
I included a few small fixes for bugs I ran into trying to get the PyPI package to run so it should run with normal use, including fixing runs using the catalog generated by discovery mode. It looks like the metadata naming convention was changed previously, so to get it working without these changes I had to manually update the metadata references in the generated catalog to use
currencyinstead oftap-criteo.currency. The catalog itself also wasn't referenced correctly when it was provided as an argument, and it was saving the bookmark instate.jsonwith an incorrect format that made subsequent runs after the first fail.Manual QA steps
python3 setup.py sdist bdist_wheeland ensurebuild/lib/tap_criteo/metadataexists.python3 -m tap_criteo.__init__ -c ../criteo_config.json --discover > catalog.jsonpython3 -m tap_criteo.__init__ -c ../criteo_config.json --catalog ../catalog.json --state ../state.json | ../virtualenv/target-csv/bin/target-csvand ensure output contains fields as expected.Risks
Rollback steps