-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot find name 'unknown'. #36
Comments
Type-fest uses the I wonder if there's a way to show a nicer error explaining which TS version is required at a minimum? |
I don't think that this library will work for TS < 3.2 becase we now use |
@angular/[email protected] requires typescript@'>=2.7.2 <2.10' but 3.4.5 was found instead. Please run the following command to install a compatible version of TypeScript.
To disable this warning run "ng config cli.warnings.typescriptMismatch false". Basically, i need to update my Angular project to the latest Angular 7 if i want to use this library |
@BendingBender I think we add |
Sounds good to me. Let's try this out. |
My experiences with peer dependencies range from "doesn't work at all" to "gives a bunch of invalid warnings" 😉 but at the very least it will document minimal TS version in the package.json, so that's a win. 😄 |
Actually, this was a bad idea. It means it now complains about TypeScript in a non-TS project that uses |
platform: win10
ERROR in node_modules/type-fest/index.d.ts(20,23): error TS2304: Cannot find name 'unknown'.
node_modules/type-fest/index.d.ts(61,30): error TS2304: Cannot find name 'unknown'.
node_modules/type-fest/source/package-json.d.ts(60,28): error TS2304: Cannot find name 'unknown'.
node_modules/type-fest/source/package-json.d.ts(375,24): error TS2304: Cannot find name 'unknown'.
node_modules/type-fest/source/package-json.d.ts(486,21): error TS2304: Cannot find name 'unknown'.
node_modules/type-fest/source/package-json.d.ts(493,17): error TS2304: Cannot find name 'unknown'.
The text was updated successfully, but these errors were encountered: