From 59cd0ed6a4cf8917fdc2c039e86b0dcff1a312cc Mon Sep 17 00:00:00 2001 From: Artur <26014458+xout@users.noreply.github.com> Date: Fri, 13 Sep 2019 22:53:05 +0200 Subject: [PATCH 1/4] Fix function overload Replace function overload with optional parameter --- index.d.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/index.d.ts b/index.d.ts index 4ff732e..cab2c83 100644 --- a/index.d.ts +++ b/index.d.ts @@ -16,7 +16,6 @@ randomInt(10, 100); //=> 54 ``` */ -declare function randomInt(maximum?: number): number; -declare function randomInt(minimum: number, maximum: number): number; +declare function randomInt(minimum: number, maximum?: number): number; export = randomInt; From 9c6a65a9c43b7ee8221409aeafe3cba11539eb18 Mon Sep 17 00:00:00 2001 From: Artur <26014458+xout@users.noreply.github.com> Date: Fri, 13 Sep 2019 23:13:59 +0200 Subject: [PATCH 2/4] Remove case without arguments --- index.test-d.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/index.test-d.ts b/index.test-d.ts index 28764cd..db519c2 100644 --- a/index.test-d.ts +++ b/index.test-d.ts @@ -1,6 +1,5 @@ import {expectType} from 'tsd'; import randomInt = require('.'); -expectType(randomInt()); expectType(randomInt(5)); expectType(randomInt(10, 100)); From c3c68b81ab35b5e0510a338fe3c77b7c4e4b7a69 Mon Sep 17 00:00:00 2001 From: Artur <26014458+xout@users.noreply.github.com> Date: Sat, 14 Sep 2019 09:50:11 +0200 Subject: [PATCH 3/4] Allow call with zero arguments --- index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.d.ts b/index.d.ts index cab2c83..bcc075a 100644 --- a/index.d.ts +++ b/index.d.ts @@ -16,6 +16,6 @@ randomInt(10, 100); //=> 54 ``` */ -declare function randomInt(minimum: number, maximum?: number): number; +declare function randomInt(minimum?: number, maximum?: number): number; export = randomInt; From d1703c41fd58643a8b33c1ef3eda586a59fcd9ca Mon Sep 17 00:00:00 2001 From: Artur <26014458+xout@users.noreply.github.com> Date: Sat, 14 Sep 2019 09:55:08 +0200 Subject: [PATCH 4/4] Revert "Remove case without arguments" This reverts commit 9c6a65a9c43b7ee8221409aeafe3cba11539eb18. --- index.test-d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/index.test-d.ts b/index.test-d.ts index db519c2..28764cd 100644 --- a/index.test-d.ts +++ b/index.test-d.ts @@ -1,5 +1,6 @@ import {expectType} from 'tsd'; import randomInt = require('.'); +expectType(randomInt()); expectType(randomInt(5)); expectType(randomInt(10, 100));