Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture webpage with device frame #367

Open
nsisodiya opened this issue May 16, 2019 · 3 comments
Open

Capture webpage with device frame #367

nsisodiya opened this issue May 16, 2019 · 3 comments

Comments

@nsisodiya
Copy link

It will be great to have a feature like Adding a device frame while capturing the webpage.
something like this.

image

@sindresorhus
Copy link
Owner

Yes, that would be nice indeed. I would only really care about the latest iPhone, iPad, and some of the latest most popular Android phones.

Would need to be implemented in https://github.com/sindresorhus/capture-website, which is the underlying library.

@sindresorhus sindresorhus changed the title Capture webpage with Device frame Capture webpage with device frame May 20, 2019
@nsisodiya
Copy link
Author

@sindresorhus If you provide little help, I can try to add this feature. Maybe like which libraries I should use to join two images (actual image + outside image of the device frame) or similar thing.

@nsisodiya
Copy link
Author

I have generated a pull request to add this feature. sindresorhus/capture-website#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants